Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: media/filters/stream_parser_factory.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/stream_parser_factory.cc
diff --git a/media/filters/stream_parser_factory.cc b/media/filters/stream_parser_factory.cc
index 23218bc1959e2cfd3a229a8ad36a975dc48553e1..003cd8f697267a2ed03b7b9b0cd053e09e2f64f5 100644
--- a/media/filters/stream_parser_factory.cc
+++ b/media/filters/stream_parser_factory.cc
@@ -123,7 +123,7 @@ static int GetMP4AudioObjectType(const std::string& codec_id,
return audio_object_type;
}
- MEDIA_LOG(log_cb) << "Malformed mimetype codec '" << codec_id << "'";
+ MEDIA_LOG(DEBUG, log_cb) << "Malformed mimetype codec '" << codec_id << "'";
return -1;
}
@@ -135,8 +135,9 @@ bool ValidateMP4ACodecID(const std::string& codec_id, const LogCB& log_cb) {
return true;
}
- MEDIA_LOG(log_cb) << "Unsupported audio object type " << audio_object_type
- << " in codec '" << codec_id << "'";
+ MEDIA_LOG(DEBUG, log_cb) << "Unsupported audio object type "
+ << audio_object_type << " in codec '" << codec_id
+ << "'";
return false;
}
@@ -337,8 +338,8 @@ static bool CheckTypeAndCodecs(
return true;
}
- MEDIA_LOG(log_cb) << "A codecs parameter must be provided for '"
- << type << "'";
+ MEDIA_LOG(DEBUG, log_cb) << "A codecs parameter must be provided for '"
+ << type << "'";
return false;
}
@@ -359,8 +360,8 @@ static bool CheckTypeAndCodecs(
}
if (!found_codec) {
- MEDIA_LOG(log_cb) << "Codec '" << codec_id
- << "' is not supported for '" << type << "'";
+ MEDIA_LOG(DEBUG, log_cb) << "Codec '" << codec_id
+ << "' is not supported for '" << type << "'";
return false;
}
}

Powered by Google App Engine
This is Rietveld 408576698