Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: media/filters/source_buffer_stream_unittest.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/source_buffer_stream_unittest.cc
diff --git a/media/filters/source_buffer_stream_unittest.cc b/media/filters/source_buffer_stream_unittest.cc
index 3828d6c02ec74cfa7f45401a458f1d57b9639e57..c623f255ed36785c45c52cd96755159ef9f496b9 100644
--- a/media/filters/source_buffer_stream_unittest.cc
+++ b/media/filters/source_buffer_stream_unittest.cc
@@ -50,7 +50,7 @@ class SourceBufferStreamTest : public testing::Test {
void SetTextStream() {
video_config_ = TestVideoConfig::Invalid();
TextTrackConfig config(kTextSubtitles, "", "", "");
- stream_.reset(new SourceBufferStream(config, LogCB(), true));
+ stream_.reset(new SourceBufferStream(config, log_cb(), true));
SetStreamInfo(2, 2);
}
@@ -66,7 +66,7 @@ class SourceBufferStreamTest : public testing::Test {
false,
base::TimeDelta(),
0);
- stream_.reset(new SourceBufferStream(audio_config_, LogCB(), true));
+ stream_.reset(new SourceBufferStream(audio_config_, log_cb(), true));
// Equivalent to 2ms per frame.
SetStreamInfo(500, 500);
@@ -352,10 +352,7 @@ class SourceBufferStreamTest : public testing::Test {
<< "\nActual: " << actual.AsHumanReadableString();
}
- const LogCB log_cb() {
- return base::Bind(&SourceBufferStreamTest::DebugMediaLog,
- base::Unretained(this));
- }
+ const LogCB log_cb() { return base::Bind(&AddLogEntryForTest); }
base::TimeDelta frame_duration() const { return frame_duration_; }
@@ -628,10 +625,6 @@ class SourceBufferStreamTest : public testing::Test {
}
}
- void DebugMediaLog(const std::string& log) {
- DVLOG(1) << log;
- }
-
int frames_per_second_;
int keyframes_per_second_;
base::TimeDelta frame_duration_;

Powered by Google App Engine
This is Rietveld 408576698