media/formats/webm/webm_stream_parser.cc - Issue 1041353002: media-internals: Differentiate error, info, and debug log messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/webm/webm_stream_parser.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attempt to fix android compile error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/formats/mpeg/adts_stream_parser.cc ('K') | « media/formats/webm/webm_content_encodings_client.cc ('k') | media/formats/webm/webm_tracks_parser.cc » ('j') | media/mojo/services/mojo_renderer_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/formats/webm/webm_stream_parser.cc

diff --git a/media/formats/webm/webm_stream_parser.cc b/media/formats/webm/webm_stream_parser.cc

index b81aac4b733f060166e888a6a33d7a5eb8e31d7e..5ada10e70eda5db365cd4845ebd498d03070a00d 100644

--- a/media/formats/webm/webm_stream_parser.cc

+++ b/media/formats/webm/webm_stream_parser.cc

@@ -155,7 +155,7 @@ int WebMStreamParser::ParseInfoAndTracks(const uint8* data, int size) {

break;

case kWebMIdCluster:

if (!cluster_parser_) {

- MEDIA_LOG(log_cb_) << "Found Cluster element before Info.";

+ MEDIA_LOG(log_cb_, ERROR) << "Found Cluster element before Info.";

return -1;

}

ChangeState(kParsingClusters);

@@ -173,7 +173,7 @@ int WebMStreamParser::ParseInfoAndTracks(const uint8* data, int size) {

// We've found the element we are looking for.

break;

default: {

- MEDIA_LOG(log_cb_) << "Unexpected element ID 0x" << std::hex << id;

+ MEDIA_LOG(log_cb_, ERROR) << "Unexpected element ID 0x" << std::hex << id;

return -1;

}