media-internals: Differentiate error, info, and debug log messages

media/mojo/services/mojo_renderer_service.cc

Index: media/mojo/services/mojo_renderer_service.cc
diff --git a/media/mojo/services/mojo_renderer_service.cc b/media/mojo/services/mojo_renderer_service.cc
index d4d2c9aec29e32aeb2c16e37d51261a256e3e430..6de974ddd8fa94ccd2f13bb4242b110aa1fd0a5b 100644
--- a/media/mojo/services/mojo_renderer_service.cc
+++ b/media/mojo/services/mojo_renderer_service.cc
@@ -25,9 +25,10 @@ namespace media {
 // Time interval to update media time.
 const int kTimeUpdateIntervalMs = 50;
 
-static void LogMediaSourceError(const scoped_refptr<MediaLog>& media_log,
-                                const std::string& error) {
-  media_log->AddEvent(media_log->CreateMediaSourceErrorEvent(error));
+static void AddLogEntry(const scoped_refptr<MediaLog>& media_log,
+                        MediaLog::MediaLogLevel level,
+                        const std::string& message) {
+  media_log->AddEvent(media_log->CreateLogEvent(level, message));

[DaleCurtis, 2015/03/31 00:12:26]

Separately from this CL, I wonder if we should just have AddEvent(level,
message) instead of every location needing to call CreateLogEvent too.

[wolenetz, 2015/03/31 00:30:11]

sgtm. I'll put something together after this CL to do that, though would
probably call it "AddLogEvent(level, message)" to reduce confusion with the
virtual AddEvent() interface that would need to remain (and that it would use).

 }
 
 static void PaintNothing(const scoped_refptr<VideoFrame>& frame) {
@@ -50,14 +51,14 @@ MojoRendererService::MojoRendererService()
       task_runner, audio_renderer_sink_.get(),
       renderer_config->GetAudioDecoders(
                            task_runner,
-                           base::Bind(&LogMediaSourceError, media_log)).Pass(),
+                           base::Bind(&AddLogEntry, media_log)).Pass(),
       renderer_config->GetAudioHardwareConfig(), media_log));
 
   scoped_ptr<VideoRenderer> video_renderer(new VideoRendererImpl(
       task_runner,
       renderer_config->GetVideoDecoders(
                            task_runner,
-                           base::Bind(&LogMediaSourceError, media_log)).Pass(),
+                           base::Bind(&AddLogEntry, media_log)).Pass(),
       true, media_log));
 
   // Create renderer.