media/formats/mpeg/mpeg_audio_stream_parser_base.cc - Issue 1041353002: media-internals: Differentiate error, info, and debug log messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mpeg/mpeg_audio_stream_parser_base.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attempt to fix android compile error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/formats/mpeg/adts_stream_parser.cc ('K') | « media/formats/mpeg/mpeg1_audio_stream_parser.cc ('k') | media/formats/webm/webm_audio_client.cc » ('j') | media/mojo/services/mojo_renderer_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/formats/mpeg/mpeg_audio_stream_parser_base.cc

diff --git a/media/formats/mpeg/mpeg_audio_stream_parser_base.cc b/media/formats/mpeg/mpeg_audio_stream_parser_base.cc

index 2a5895f5a47d1462f5cb6b2f2660eff3d06d53af..733c398c6ceff3e187a26d3a5e82cecc84b50fda 100644

--- a/media/formats/mpeg/mpeg_audio_stream_parser_base.cc

+++ b/media/formats/mpeg/mpeg_audio_stream_parser_base.cc

@@ -262,7 +262,7 @@ int MPEGAudioStreamParserBase::ParseIcecastHeader(const uint8* data, int size) {

int offset = LocateEndOfHeaders(data, locate_size, 4);

if (offset < 0) {

if (locate_size == kMaxIcecastHeaderSize) {

- MEDIA_LOG(log_cb_) << "Icecast header is too large.";

+ MEDIA_LOG(log_cb_, ERROR) << "Icecast header is too large.";

return -1;

}

@@ -323,7 +323,7 @@ bool MPEGAudioStreamParserBase::ParseSyncSafeInt(BitReader* reader,

for (int i = 0; i < 4; ++i) {

uint8 tmp;

if (!reader->ReadBits(1, &tmp) || tmp != 0) {

- MEDIA_LOG(log_cb_) << "ID3 syncsafe integer byte MSb is not 0!";

+ MEDIA_LOG(log_cb_, ERROR) << "ID3 syncsafe integer byte MSb is not 0!";

return false;

}