Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1041213004: Web MIDI API: update open() and close() implementation (Closed)

Created:
5 years, 8 months ago by Takashi Toyoshima
Modified:
5 years, 8 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@midi_wd
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web MIDI API: update open() and close() implementation Update the implementation algorithm to conform the latest WD, http://www.w3.org/TR/2015/WD-webmidi-20150317/. BUG=462183 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192832

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase 2 #

Patch Set 4 : fix rebase errors #

Total comments: 2

Patch Set 5 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -26 lines) Patch
M LayoutTests/webmidi/open_close.html View 1 2 3 4 2 chunks +9 lines, -2 lines 0 comments Download
M LayoutTests/webmidi/open_close-expected.txt View 2 chunks +10 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.cpp View 1 2 3 2 chunks +20 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Takashi Toyoshima
ptal
5 years, 8 months ago (2015-03-30 17:51:59 UTC) #2
yhirano
lgtm https://codereview.chromium.org/1041213004/diff/60001/LayoutTests/webmidi/open_close.html File LayoutTests/webmidi/open_close.html (right): https://codereview.chromium.org/1041213004/diff/60001/LayoutTests/webmidi/open_close.html#newcode16 LayoutTests/webmidi/open_close.html:16: checkHandler = function(e) { var
5 years, 8 months ago (2015-03-31 07:27:20 UTC) #3
Takashi Toyoshima
https://codereview.chromium.org/1041213004/diff/60001/LayoutTests/webmidi/open_close.html File LayoutTests/webmidi/open_close.html (right): https://codereview.chromium.org/1041213004/diff/60001/LayoutTests/webmidi/open_close.html#newcode16 LayoutTests/webmidi/open_close.html:16: checkHandler = function(e) { On 2015/03/31 07:27:20, yhirano wrote: ...
5 years, 8 months ago (2015-03-31 11:22:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041213004/80001
5 years, 8 months ago (2015-03-31 11:23:26 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 13:43:41 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192832

Powered by Google App Engine
This is Rietveld 408576698