Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1041153002: Rearrange some includes for core/layout/svg/SVGText* (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rearrange some includes for core/layout/svg/SVGText* LayoutSVGResourceMasker.h came along for the ride too. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M Source/core/layout/svg/LayoutSVGResourceMasker.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/layout/svg/SVGTextChunk.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/layout/svg/SVGTextChunkBuilder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextChunkBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributes.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributes.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngineBaseline.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngineSpacing.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Was looking at these because they were fairly high up in the list of "files ...
5 years, 8 months ago (2015-03-30 11:22:55 UTC) #2
Erik Dahlström (inactive)
lgtm
5 years, 8 months ago (2015-03-30 11:33:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041153002/1
5 years, 8 months ago (2015-03-30 12:03:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 12:10:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192754

Powered by Google App Engine
This is Rietveld 408576698