PartitionAlloc: Centralize Partition allocators into one place (Part 1)

PartitionAlloc: Centralize Partition allocators into one place (Part 1)

Currently partitions allocators are scattered in multiple places in the code base
(i.e., wtf/WTF.h, wtf/FastMalloc.h, platform/Partitions.h) and it's hard
to collect PartitionAlloc-wide profiling data (e.g., how much memory is consumed in
PartitionAlloc).

As a first step, this CL merges platform/Partitions.h into wtf/WTF.h.
Also this CL renames wtf/WTF.h to wtf/Partitions.h.

BUG=471650
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192809

[haraken, 2015-03-30 05:47:52]

haraken@chromium.org changed reviewers:
+ cevans@chromium.org, oilpan-reviews@chromium.org, tsepez@chromium.org

[haraken, 2015-03-30 05:47:53]

PTAL

In essence, this CL is a trivial change. Just merged platform/Partitions.h into
wtf/WTF.h, and renamed wtf/WTF.h to wtf/Partitions.h.

[Chris Evans, 2015-03-30 18:41:36]

LGTM

https://codereview.chromium.org/1041103002/diff/1/Source/wtf/Partitions.cpp
File Source/wtf/Partitions.cpp (right):

https://codereview.chromium.org/1041103002/diff/1/Source/wtf/Partitions.cpp#n...
Source/wtf/Partitions.cpp:98: m_bufferAllocator.shutdown();
Nit: we're also ignoring a fairly useful return code from this third shutdown,
so I recommend making it explicit that this is deliberate too with another
(void) prefix.

https://codereview.chromium.org/1041103002/diff/1/Source/wtf/Partitions.h
File Source/wtf/Partitions.h (right):

https://codereview.chromium.org/1041103002/diff/1/Source/wtf/Partitions.h#new...
Source/wtf/Partitions.h:57: ALWAYS_INLINE static PartitionRoot*
getObjectModelPartition() { return m_objectModelAllocator.root(); }
Nit: "ALWAYS_INLINE static" is a different ordering to "static ALWAYS_INLINE".
I'm not sure which is correct, but they should be the same :-)

[Tom Sepez, 2015-03-30 18:53:11]

lgtm

[haraken, 2015-03-30 23:06:18]

Thanks for review.

https://codereview.chromium.org/1041103002/diff/1/Source/wtf/Partitions.cpp
File Source/wtf/Partitions.cpp (right):

https://codereview.chromium.org/1041103002/diff/1/Source/wtf/Partitions.cpp#n...
Source/wtf/Partitions.cpp:98: m_bufferAllocator.shutdown();
On 2015/03/30 18:41:36, Chris Evans wrote:
> Nit: we're also ignoring a fairly useful return code from this third shutdown,
> so I recommend making it explicit that this is deliberate too with another
> (void) prefix.

Done.

https://codereview.chromium.org/1041103002/diff/1/Source/wtf/Partitions.h
File Source/wtf/Partitions.h (right):

https://codereview.chromium.org/1041103002/diff/1/Source/wtf/Partitions.h#new...
Source/wtf/Partitions.h:57: ALWAYS_INLINE static PartitionRoot*
getObjectModelPartition() { return m_objectModelAllocator.root(); }
On 2015/03/30 18:41:36, Chris Evans wrote:
> Nit: "ALWAYS_INLINE static" is a different ordering to "static ALWAYS_INLINE".
> I'm not sure which is correct, but they should be the same :-)

Blink mixes both, but it seems 'ALWAYS_INLINE static' is more popular. Used
'ALWAYS_INLINE static' consistently in this file.

[haraken, 2015-03-30 23:06:22]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-03-30 23:06:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
cevans@chromium.org
Link to the patchset: https://codereview.chromium.org/1041103002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-03-30 23:06:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1041103002/20001

[commit-bot: I haz the power, 2015-03-30 23:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-30 23:38:04]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[haraken, 2015-03-30 23:55:02]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-03-30 23:55:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
cevans@chromium.org
Link to the patchset: https://codereview.chromium.org/1041103002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-03-30 23:55:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1041103002/40001

[commit-bot: I haz the power, 2015-03-31 01:10:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 01:10:08]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[haraken, 2015-03-31 05:34:22]

Fixed broken tests. Landing.

[haraken, 2015-03-31 05:34:26]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-03-31 05:34:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
cevans@chromium.org
Link to the patchset: https://codereview.chromium.org/1041103002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-03-31 05:34:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1041103002/100001

[commit-bot: I haz the power, 2015-03-31 07:07:54]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192809