Source/modules/serviceworkers/ServiceWorkerGlobalScope.h - Issue 1041053005: Oilpan: fix WorkerThreadStartupData finalization handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Issue 1041053005: Oilpan: fix WorkerThreadStartupData finalization handling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add comment clarifying use of CrossThreadPersistent<> Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

index 5514e881b63500d8b451ed2b0c0dbe66f035a224..d27d9893820a4a0f82de5a554737d8d85c7bea7a 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

@@ -56,7 +56,7 @@ typedef RequestOrUSVString RequestInfo;

class ServiceWorkerGlobalScope final : public WorkerGlobalScope {

DEFINE_WRAPPERTYPEINFO();

public:

- static PassRefPtrWillBeRawPtr<ServiceWorkerGlobalScope> create(ServiceWorkerThread*, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

+ static PassRefPtrWillBeRawPtr<ServiceWorkerGlobalScope> create(ServiceWorkerThread*, PassOwnPtr<WorkerThreadStartupData>);

virtual ~ServiceWorkerGlobalScope();

virtual bool isServiceWorkerGlobalScope() const override { return true; }