Source/modules/compositorworker/CompositorWorkerThread.cpp - Issue 1041053005: Oilpan: fix WorkerThreadStartupData finalization handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/compositorworker/CompositorWorkerThread.cpp

Issue 1041053005: Oilpan: fix WorkerThreadStartupData finalization handling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add comment clarifying use of CrossThreadPersistent<> Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/compositorworker/CompositorWorkerThread.h ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/compositorworker/CompositorWorkerThread.cpp

diff --git a/Source/modules/compositorworker/CompositorWorkerThread.cpp b/Source/modules/compositorworker/CompositorWorkerThread.cpp

index d9c00413f46017af15bc04ecc390450b1e18ca38..3b92104e883cc35ef8faf46d747cbaa08926279e 100644

--- a/Source/modules/compositorworker/CompositorWorkerThread.cpp

+++ b/Source/modules/compositorworker/CompositorWorkerThread.cpp

@@ -13,13 +13,13 @@

namespace blink {

-PassRefPtr<CompositorWorkerThread> CompositorWorkerThread::create(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, WorkerObjectProxy& workerObjectProxy, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

+PassRefPtr<CompositorWorkerThread> CompositorWorkerThread::create(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, WorkerObjectProxy& workerObjectProxy, double timeOrigin, PassOwnPtr<WorkerThreadStartupData> startupData)

{

ASSERT(isMainThread());

return adoptRef(new CompositorWorkerThread(workerLoaderProxy, workerObjectProxy, timeOrigin, startupData));

}

-CompositorWorkerThread::CompositorWorkerThread(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, WorkerObjectProxy& workerObjectProxy, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

+CompositorWorkerThread::CompositorWorkerThread(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, WorkerObjectProxy& workerObjectProxy, double timeOrigin, PassOwnPtr<WorkerThreadStartupData> startupData)

: WorkerThread(workerLoaderProxy, workerObjectProxy, startupData)

, m_workerObjectProxy(workerObjectProxy)

, m_timeOrigin(timeOrigin)

@@ -30,7 +30,7 @@ CompositorWorkerThread::~CompositorWorkerThread()

{

}

-PassRefPtrWillBeRawPtr<WorkerGlobalScope> CompositorWorkerThread::createWorkerGlobalScope(PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

+PassRefPtrWillBeRawPtr<WorkerGlobalScope> CompositorWorkerThread::createWorkerGlobalScope(PassOwnPtr<WorkerThreadStartupData> startupData)

{

return CompositorWorkerGlobalScope::create(this, startupData, m_timeOrigin);

}