Chromium Code Reviews| Index: Source/core/html/HTMLIFrameElement.cpp |
| diff --git a/Source/core/html/HTMLIFrameElement.cpp b/Source/core/html/HTMLIFrameElement.cpp |
| index 2e752d7493cae9b854a1a7336ba2af78f053797e..69429c5c947e334f3c9cb208d7d09d17538de8ec 100644 |
| --- a/Source/core/html/HTMLIFrameElement.cpp |
| +++ b/Source/core/html/HTMLIFrameElement.cpp |
| @@ -163,12 +163,15 @@ bool HTMLIFrameElement::isInteractiveContent() const |
| return true; |
| } |
| -void HTMLIFrameElement::valueChanged() |
| +void HTMLIFrameElement::valueChanged(DOMSettableTokenList* tokenList) |
| { |
| - String invalidTokens; |
| - setSandboxFlags(m_sandbox->value().isNull() ? SandboxNone : parseSandboxPolicy(m_sandbox->tokens(), invalidTokens)); |
| - if (!invalidTokens.isNull()) |
| - document().addConsoleMessage(ConsoleMessage::create(OtherMessageSource, ErrorMessageLevel, "Error while parsing the 'sandbox' attribute: " + invalidTokens)); |
| + if (tokenList == m_sandbox) { |
|
Mike West
2015/03/30 05:01:57
When wouldn't this be true? Can you either `ASSERT
hyunjunekim2
2015/03/30 07:02:51
If HTMLIFrameElement has two DOMSettableTokenList,
Mike West
2015/03/30 09:01:33
But HTMLIFrameElement doesn't have two DOMSettable
hyunjunekim2
2015/03/30 09:16:22
Ok, I'm wrong, It's also my mistake. After file a
|
| + String invalidTokens; |
| + setSandboxFlags(m_sandbox->value().isNull() ? SandboxNone : parseSandboxPolicy(m_sandbox->tokens(), invalidTokens)); |
| + if (!invalidTokens.isNull()) |
| + document().addConsoleMessage(ConsoleMessage::create(OtherMessageSource, ErrorMessageLevel, "Error while parsing the 'sandbox' attribute: " + invalidTokens)); |
| + setSynchronizedLazyAttribute(sandboxAttr, m_sandbox->value()); |
|
Mike West
2015/03/30 05:01:57
This line is the only actual change in the patch,
hyunjunekim2
2015/03/30 07:02:51
I have a reason adding this one. Because it add th
|
| + } |
| } |
| } |