Source/core/html/HTMLIFrameElement.h - Issue 1040943002: When call getAttribute, HTMLIFrame.sandbox has a bug which don't return changed value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLIFrameElement.h

Issue 1040943002: When call getAttribute, HTMLIFrame.sandbox has a bug which don't return changed value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modify a test-case for Layout Test. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLIFrameElement.h

diff --git a/Source/core/html/HTMLIFrameElement.h b/Source/core/html/HTMLIFrameElement.h

index 2e99bbfebac2c36d6398bcf99a57769bdf51db8a..10b133f41c36191d5b44b544cc2ff306ff402776 100644

--- a/Source/core/html/HTMLIFrameElement.h

+++ b/Source/core/html/HTMLIFrameElement.h

@@ -56,7 +56,7 @@ private:

virtual void didLoadNonEmptyDocument() override { m_didLoadNonEmptyDocument = true; }

virtual bool isInteractiveContent() const override;

- virtual void valueChanged() override;

+ virtual void valueChanged(DOMSettableTokenList*) override;

AtomicString m_name;

bool m_didLoadNonEmptyDocument;

« no previous file with comments | « Source/core/dom/DOMSettableTokenList.cpp ('k') | Source/core/html/HTMLIFrameElement.cpp » ('j') | Source/core/html/HTMLIFrameElement.cpp » ('J')