Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1040653002: Don't call OnRegistrationDeleted when the unregistration failed. (Closed)

Created:
5 years, 9 months ago by horo
Modified:
5 years, 9 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't call OnRegistrationDeleted when the unregistration failed. BUG= Committed: https://crrev.com/9fe1bd708a7c749f93527e79489327a0b44c57bb Cr-Commit-Position: refs/heads/master@{#322555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_context_core.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
horo
falken@ Could you please review this?
5 years, 9 months ago (2015-03-27 09:36:20 UTC) #2
falken
On 2015/03/27 09:36:20, horo wrote: > falken@ > Could you please review this? lgtm
5 years, 9 months ago (2015-03-27 09:40:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040653002/1
5 years, 9 months ago (2015-03-27 09:42:57 UTC) #5
nhiroki
Just curious: Have you seen any bug related to this? (change itself looks good to ...
5 years, 9 months ago (2015-03-27 09:46:38 UTC) #6
horo
On 2015/03/27 09:46:38, nhiroki wrote: > Just curious: Have you seen any bug related to ...
5 years, 9 months ago (2015-03-27 09:52:19 UTC) #7
nhiroki
On 2015/03/27 09:52:19, horo wrote: > On 2015/03/27 09:46:38, nhiroki wrote: > > Just curious: ...
5 years, 9 months ago (2015-03-27 10:00:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 11:38:32 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 11:39:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fe1bd708a7c749f93527e79489327a0b44c57bb
Cr-Commit-Position: refs/heads/master@{#322555}

Powered by Google App Engine
This is Rietveld 408576698