Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 1040653002: Don't call OnRegistrationDeleted when the unregistration failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 1cc9387adfce4de9033d13bce069f9f87863d014..376db13a90dd0354695fce9fc649a87515fccb47 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -356,7 +356,7 @@ void ServiceWorkerContextCore::UnregistrationComplete(
int64 registration_id,
ServiceWorkerStatusCode status) {
callback.Run(status);
- if (observer_list_.get()) {
+ if (status == SERVICE_WORKER_OK && observer_list_.get()) {
observer_list_->Notify(FROM_HERE,
&ServiceWorkerContextObserver::OnRegistrationDeleted,
registration_id, pattern);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698