Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: content/common/sandbox_win.cc

Issue 1040223002: Added metrics to track sandboxed process launch errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index 7749d7bd84ec34591edb4d02a71fc20b449f9b85..0211a1c73ced3af904dfba9bd1df4bf84585f9f6 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -741,10 +741,10 @@ base::Process StartSandboxedProcess(
// cause for lowbox/createprocess errors.
sandbox::PolicyBase* policy_base =
static_cast<sandbox::PolicyBase*>(policy);
- if (policy_base->GetLowBoxSid()) {
- UMA_HISTOGRAM_SPARSE_SLOWLY("Process.Sandbox.Lowbox.Launch.Error",
- last_error);
- }
+ UMA_HISTOGRAM_SPARSE_SLOWLY(policy_base->GetLowBoxSid() ?
+ "Process.Sandbox.Lowbox.Launch.Error" :
+ "Process.Sandbox.Launch.Error",
+ last_error);
} else
DLOG(ERROR) << "Failed to launch process. Error: " << result;
return base::Process();
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698