Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1040223002: Added metrics to track sandboxed process launch errors. (Closed)

Created:
5 years, 8 months ago by Shrikant Kelkar
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added metrics to track sandboxed process launch errors. Have already added metrics to track create process errors when lowbox token is present (https://codereview.chromium.org/1024463005/), which still remains a mystery. Now adding general sandboxed create process error so that we can establish a baseline. BUG=468922 R=jschuh@chromium.org,cpu@chromium.org,isherman@chromium.org Committed: https://crrev.com/98322129c764d4c8f39df2a8e8ae770939ec1d9a Cr-Commit-Position: refs/heads/master@{#323165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/common/sandbox_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Shrikant Kelkar
5 years, 8 months ago (2015-03-30 22:51:23 UTC) #1
Ilya Sherman
LGTM
5 years, 8 months ago (2015-03-30 23:31:10 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 8 months ago (2015-03-31 23:42:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040223002/1
5 years, 8 months ago (2015-03-31 23:43:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 01:36:05 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 01:36:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98322129c764d4c8f39df2a8e8ae770939ec1d9a
Cr-Commit-Position: refs/heads/master@{#323165}

Powered by Google App Engine
This is Rietveld 408576698