Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1040103002: [DevTools] Cleanup Page domain calls, which should be Emulation calls. (Closed)

Created:
5 years, 8 months ago by dgozman
Modified:
5 years, 8 months ago
Reviewers:
sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Cleanup Page domain calls, which should be Emulation calls. BUG=467059 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192765

Patch Set 1 #

Patch Set 2 : supportsRendering to RenderingOptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/device-orientation-success.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/geolocation-emulation-tests.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector/geolocation-emulation-tests-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/main/RenderingOptions.js View 1 2 chunks +20 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dgozman
Take a look please.
5 years, 8 months ago (2015-03-30 14:06:56 UTC) #2
sergeyv
lgtm
5 years, 8 months ago (2015-03-30 14:19:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040103002/20001
5 years, 8 months ago (2015-03-30 14:59:53 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 16:31:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192765

Powered by Google App Engine
This is Rietveld 408576698