Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: Source/devtools/front_end/main/RenderingOptions.js

Issue 1040103002: [DevTools] Cleanup Page domain calls, which should be Emulation calls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: supportsRendering to RenderingOptions Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/main/RenderingOptions.js
diff --git a/Source/devtools/front_end/main/RenderingOptions.js b/Source/devtools/front_end/main/RenderingOptions.js
index 63dfd1a18bad8ec21079737002f0d09beaa87b06..e7da89fb5d6669dd273d3c9e7f3e0239e688c0c2 100644
--- a/Source/devtools/front_end/main/RenderingOptions.js
+++ b/Source/devtools/front_end/main/RenderingOptions.js
@@ -49,11 +49,23 @@ WebInspector.RenderingOptions = function()
WebInspector.RenderingOptions.prototype = {
/**
+ * @param {!WebInspector.Target} target
+ * @return {boolean}
+ */
+ supportsRendering: function(target)
+ {
+ return target.isPage();
+ },
+
+ /**
* @override
* @param {!WebInspector.Target} target
*/
targetAdded: function(target)
{
+ if (this.supportsRendering(target))
+ return;
+
var settings = this._setterNames.keysArray();
for (var i = 0; i < settings.length; ++i) {
var setting = settings[i];
@@ -79,13 +91,18 @@ WebInspector.RenderingOptions.prototype = {
_mapSettingToSetter: function(setting, setterName)
{
this._setterNames.set(setting, setterName);
- setting.addChangeListener(changeListener);
+ setting.addChangeListener(changeListener.bind(this));
+ /**
+ * @this {WebInspector.RenderingOptions}
+ */
function changeListener()
{
var targets = WebInspector.targetManager.targets();
- for (var i = 0; i < targets.length; ++i)
- targets[i].renderingAgent()[setterName](setting.get());
+ for (var i = 0; i < targets.length; ++i) {
+ if (this.supportsRendering(targets[i]))
+ targets[i].renderingAgent()[setterName](setting.get());
+ }
}
}
}
« no previous file with comments | « LayoutTests/inspector/geolocation-emulation-tests-expected.txt ('k') | Source/devtools/front_end/sdk/OverridesSupport.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698