Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1040073002: [bindings] Remove XMLHttpRequest CustomConstructor (Closed)

Created:
5 years, 8 months ago by vivekg_samsung
Modified:
5 years, 8 months ago
Reviewers:
haraken, vivekg, jsbell, yhirano
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, Inactive, tyoshino+watch_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Remove XMLHttpRequest CustomConstructor Accept the ScriptState as argument to XMLHttpRequest constructor to remove the custom binding as per [1] BUG=345519 R=haraken@chromium.org, yhirano@chromium.org [1] https://xhr.spec.whatwg.org/#interface-xmlhttprequest Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192816

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added spec link #

Total comments: 2

Patch Set 3 : Patch for landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.idl View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
vivekg
PTAL, thanks.
5 years, 8 months ago (2015-03-30 11:02:45 UTC) #2
jsbell
https://codereview.chromium.org/1040073002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.idl File Source/core/xmlhttprequest/XMLHttpRequest.idl (right): https://codereview.chromium.org/1040073002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.idl#newcode29 Source/core/xmlhttprequest/XMLHttpRequest.idl:29: enum XMLHttpRequestResponseType { Drive-by: Can you add a link ...
5 years, 8 months ago (2015-03-30 16:55:06 UTC) #4
vivekg
On 2015/03/30 at 16:55:06, jsbell wrote: > https://codereview.chromium.org/1040073002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.idl > File Source/core/xmlhttprequest/XMLHttpRequest.idl (right): > > https://codereview.chromium.org/1040073002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.idl#newcode29 ...
5 years, 8 months ago (2015-03-30 20:49:56 UTC) #5
vivekg
Friendly ping :)
5 years, 8 months ago (2015-03-31 06:25:31 UTC) #6
yhirano
lgtm https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequest/XMLHttpRequest.cpp File Source/core/xmlhttprequest/XMLHttpRequest.cpp (right): https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequest/XMLHttpRequest.cpp#newcode25 Source/core/xmlhttprequest/XMLHttpRequest.cpp:25: +bindings/core/v8/DOMWrapperWorld.h https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequest/XMLHttpRequest.cpp#newcode26 Source/core/xmlhttprequest/XMLHttpRequest.cpp:26: #include "bindings/core/v8/ExceptionState.h" +bindings/core/v8/ScriptState.h
5 years, 8 months ago (2015-03-31 06:41:56 UTC) #7
haraken
LGTM
5 years, 8 months ago (2015-03-31 06:47:48 UTC) #8
vivekg
On 2015/03/31 at 06:41:56, yhirano wrote: > lgtm > > https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequest/XMLHttpRequest.cpp > File Source/core/xmlhttprequest/XMLHttpRequest.cpp (right): ...
5 years, 8 months ago (2015-03-31 06:48:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040073002/40001
5 years, 8 months ago (2015-03-31 06:48:52 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 09:04:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192816

Powered by Google App Engine
This is Rietveld 408576698