[bindings] Remove XMLHttpRequest CustomConstructor

[bindings] Remove XMLHttpRequest CustomConstructor

Accept the ScriptState as argument to XMLHttpRequest constructor to remove the custom binding as per [1]

BUG=345519
R=haraken@chromium.org, yhirano@chromium.org

[1] https://xhr.spec.whatwg.org/#interface-xmlhttprequest

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192816

[vivekg, 2015-03-30 11:02:44]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-03-30 11:02:45]

PTAL, thanks.

[jsbell, 2015-03-30 16:55:06]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2015-03-30 16:55:06]

https://codereview.chromium.org/1040073002/diff/1/Source/core/xmlhttprequest/...
File Source/core/xmlhttprequest/XMLHttpRequest.idl (right):

https://codereview.chromium.org/1040073002/diff/1/Source/core/xmlhttprequest/...
Source/core/xmlhttprequest/XMLHttpRequest.idl:29: enum
XMLHttpRequestResponseType {
Drive-by: Can you add a link to the spec as a comment to the IDL file?

// https://xhr.spec.whatwg.org/#interface-xmlhttprequest

[vivekg, 2015-03-30 20:49:56]

On 2015/03/30 at 16:55:06, jsbell wrote:
>
https://codereview.chromium.org/1040073002/diff/1/Source/core/xmlhttprequest/...
> File Source/core/xmlhttprequest/XMLHttpRequest.idl (right):
> 
>
https://codereview.chromium.org/1040073002/diff/1/Source/core/xmlhttprequest/...
> Source/core/xmlhttprequest/XMLHttpRequest.idl:29: enum
XMLHttpRequestResponseType {
> Drive-by: Can you add a link to the spec as a comment to the IDL file?
> 
> // https://xhr.spec.whatwg.org/#interface-xmlhttprequest

Done. Thank you for taking a look :)

[vivekg, 2015-03-31 06:25:31]

Friendly ping :)

[yhirano, 2015-03-31 06:41:56]

lgtm

https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequ...
File Source/core/xmlhttprequest/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequ...
Source/core/xmlhttprequest/XMLHttpRequest.cpp:25: 
+bindings/core/v8/DOMWrapperWorld.h

https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequ...
Source/core/xmlhttprequest/XMLHttpRequest.cpp:26: #include
"bindings/core/v8/ExceptionState.h"
+bindings/core/v8/ScriptState.h

[haraken, 2015-03-31 06:47:48]

LGTM

[vivekg, 2015-03-31 06:48:31]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2015-03-31 06:48:31]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1040073002/#ps40001
(title: "Patch for landing.")

[vivekg, 2015-03-31 06:48:46]

On 2015/03/31 at 06:41:56, yhirano wrote:
> lgtm
> 
>
https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequ...
> File Source/core/xmlhttprequest/XMLHttpRequest.cpp (right):
> 
>
https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequ...
> Source/core/xmlhttprequest/XMLHttpRequest.cpp:25: 
> +bindings/core/v8/DOMWrapperWorld.h
> 
>
https://codereview.chromium.org/1040073002/diff/20001/Source/core/xmlhttprequ...
> Source/core/xmlhttprequest/XMLHttpRequest.cpp:26: #include
"bindings/core/v8/ExceptionState.h"
> +bindings/core/v8/ScriptState.h

Thank you, done.

[commit-bot: I haz the power, 2015-03-31 06:48:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1040073002/40001

[commit-bot: I haz the power, 2015-03-31 09:04:29]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192816