Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 1040073002: [bindings] Remove XMLHttpRequest CustomConstructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/xmlhttprequest/XMLHttpRequest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 #include "core/dom/Document.h" 45 #include "core/dom/Document.h"
46 #include "core/inspector/InspectorInstrumentation.h" 46 #include "core/inspector/InspectorInstrumentation.h"
47 #include "core/streams/ReadableStream.h" 47 #include "core/streams/ReadableStream.h"
48 #include "core/streams/Stream.h" 48 #include "core/streams/Stream.h"
49 #include "core/workers/WorkerGlobalScope.h" 49 #include "core/workers/WorkerGlobalScope.h"
50 #include "core/xmlhttprequest/XMLHttpRequest.h" 50 #include "core/xmlhttprequest/XMLHttpRequest.h"
51 #include <v8.h> 51 #include <v8.h>
52 52
53 namespace blink { 53 namespace blink {
54 54
55 void V8XMLHttpRequest::constructorCustom(const v8::FunctionCallbackInfo<v8::Valu e>& info)
56 {
57 ExecutionContext* context = currentExecutionContext(info.GetIsolate());
58
59 RefPtr<SecurityOrigin> securityOrigin;
60 if (context->isDocument()) {
61 DOMWrapperWorld& world = DOMWrapperWorld::current(info.GetIsolate());
62 if (world.isIsolatedWorld())
63 securityOrigin = world.isolatedWorldSecurityOrigin();
64 }
65
66 RefPtrWillBeRawPtr<XMLHttpRequest> xmlHttpRequest = XMLHttpRequest::create(c ontext, securityOrigin);
67
68 v8::Handle<v8::Object> wrapper = info.Holder();
69 xmlHttpRequest->associateWithWrapper(info.GetIsolate(), xmlHttpRequest->wrap perTypeInfo(), wrapper);
70 info.GetReturnValue().Set(wrapper);
71 }
72
73 void V8XMLHttpRequest::responseTextAttributeGetterCustom(const v8::PropertyCallb ackInfo<v8::Value>& info) 55 void V8XMLHttpRequest::responseTextAttributeGetterCustom(const v8::PropertyCallb ackInfo<v8::Value>& info)
74 { 56 {
75 XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toImpl(info.Holder()); 57 XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toImpl(info.Holder());
76 ExceptionState exceptionState(ExceptionState::GetterContext, "responseText", "XMLHttpRequest", info.Holder(), info.GetIsolate()); 58 ExceptionState exceptionState(ExceptionState::GetterContext, "responseText", "XMLHttpRequest", info.Holder(), info.GetIsolate());
77 ScriptString text = xmlHttpRequest->responseText(exceptionState); 59 ScriptString text = xmlHttpRequest->responseText(exceptionState);
78 if (exceptionState.throwIfNeeded()) 60 if (exceptionState.throwIfNeeded())
79 return; 61 return;
80 if (text.isEmpty()) { 62 if (text.isEmpty()) {
81 v8SetReturnValueString(info, emptyString(), info.GetIsolate()); 63 v8SetReturnValueString(info, emptyString(), info.GetIsolate());
82 return; 64 return;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 case XMLHttpRequest::ResponseTypeArrayBuffer: 131 case XMLHttpRequest::ResponseTypeArrayBuffer:
150 { 132 {
151 DOMArrayBuffer* arrayBuffer = xmlHttpRequest->responseArrayBuffer(); 133 DOMArrayBuffer* arrayBuffer = xmlHttpRequest->responseArrayBuffer();
152 v8SetReturnValueFast(info, arrayBuffer, xmlHttpRequest); 134 v8SetReturnValueFast(info, arrayBuffer, xmlHttpRequest);
153 return; 135 return;
154 } 136 }
155 } 137 }
156 } 138 }
157 139
158 } // namespace blink 140 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/xmlhttprequest/XMLHttpRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698