[OriginChip] Always show the page info bubble when clicked.

[OriginChip] Always show the page info bubble when clicked.

The current logic assumes the location icon is associated with the URL in the Omnibox so when that URL goes away or is being edited, it no longer makes sense to show the page info associated with the original URL.

But with the origin chip in place, the location icon is associated with the host in the chip.  And that host continues to be shown whether or not a URL is shown or any editing is happening in the Omnibox.  So showing the page info is still accurate.

BUG=315944
TBR=pkasting

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240619

[msw, 2013-12-12 22:25:07]

LGTM with the include removed. Please TBR pkasting on this, as he might have
some thoughts on allowing a user to enter www.foo.com in the omnibox and still
see the chip and bubble for www.bar.com.

https://codereview.chromium.org/104003005/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/site_chip_view.cc (right):

https://codereview.chromium.org/104003005/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/site_chip_view.cc:27: #include
"chrome/browser/ui/views/location_bar/location_icon_view.h"
Remove this; it's included by the header already.

[Justin Donnelly, 2013-12-12 22:43:53]

https://codereview.chromium.org/104003005/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/site_chip_view.cc (right):

https://codereview.chromium.org/104003005/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/site_chip_view.cc:27: #include
"chrome/browser/ui/views/location_bar/location_icon_view.h"
On 2013/12/12 22:25:08, msw wrote:
> Remove this; it's included by the header already.

Oh, duh. Done.

[commit-bot: I haz the power, 2013-12-12 22:44:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/104003005/20001

[commit-bot: I haz the power, 2013-12-13 09:28:16]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-12-13 13:42:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/104003005/20001

[commit-bot: I haz the power, 2013-12-13 13:44:45]

Change committed as 240619

[Peter Kasting, 2013-12-18 00:40:26]

I'm fine with this.  I suppose we could consider whether editing in the omnibox
should make the origin chip disappear.  I raised that separately in an email to
the omnitheatre list.