Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: chrome/browser/ui/views/location_bar/page_info_helper.cc

Issue 104003005: [OriginChip] Always show the page info bubble when clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/location_bar/page_info_helper.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/page_info_helper.h" 5 #include "chrome/browser/ui/views/location_bar/page_info_helper.h"
6 6
7 #include "chrome/browser/search/search.h"
7 #include "chrome/browser/ui/omnibox/omnibox_view.h" 8 #include "chrome/browser/ui/omnibox/omnibox_view.h"
8 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" 9 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
9 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
10 #include "content/public/browser/navigation_entry.h" 11 #include "content/public/browser/navigation_entry.h"
11 #include "content/public/browser/web_contents.h" 12 #include "content/public/browser/web_contents.h"
12 #include "ui/views/view.h" 13 #include "ui/views/view.h"
13 14
14 using content::NavigationController; 15 using content::NavigationController;
15 using content::NavigationEntry; 16 using content::NavigationEntry;
16 using content::WebContents; 17 using content::WebContents;
17 18
18 PageInfoHelper::PageInfoHelper(const views::View* owner, 19 PageInfoHelper::PageInfoHelper(const views::View* owner,
19 LocationBarView* location_bar) 20 LocationBarView* location_bar)
20 : owner_(owner), 21 : owner_(owner),
21 location_bar_(location_bar) { 22 location_bar_(location_bar) {
22 } 23 }
23 24
24 void PageInfoHelper::ProcessEvent(const ui::LocatedEvent& event) { 25 void PageInfoHelper::ProcessEvent(const ui::LocatedEvent& event) {
25 if (!owner_->HitTestPoint(event.location())) 26 if (!owner_->HitTestPoint(event.location()))
26 return; 27 return;
27 28
28 // Do not show page info if the user has been editing the location 29 // Do not show page info if the user has been editing the location
29 // bar, or the location bar is at the NTP. 30 // bar, or the location bar is at the NTP.
30 if (location_bar_->GetOmniboxView()->IsEditingOrEmpty()) 31 if (location_bar_->GetOmniboxView()->IsEditingOrEmpty() &&
32 !chrome::ShouldDisplayOriginChip())
31 return; 33 return;
32 34
33 WebContents* tab = location_bar_->GetWebContents(); 35 WebContents* tab = location_bar_->GetWebContents();
34 if (!tab) 36 if (!tab)
35 return; 37 return;
36 const NavigationController& controller = tab->GetController(); 38 const NavigationController& controller = tab->GetController();
37 // Important to use GetVisibleEntry to match what's showing in the omnibox. 39 // Important to use GetVisibleEntry to match what's showing in the omnibox.
38 NavigationEntry* nav_entry = controller.GetVisibleEntry(); 40 NavigationEntry* nav_entry = controller.GetVisibleEntry();
39 if (!nav_entry) { 41 if (!nav_entry) {
40 NOTREACHED(); 42 NOTREACHED();
41 return; 43 return;
42 } 44 }
43 45
44 location_bar_->delegate()->ShowWebsiteSettings( 46 location_bar_->delegate()->ShowWebsiteSettings(
45 tab, nav_entry->GetURL(), nav_entry->GetSSL()); 47 tab, nav_entry->GetURL(), nav_entry->GetSSL());
46 } 48 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/page_info_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698