Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2065)

Unified Diff: ppapi/generators/idl_c_header.py

Issue 103993006: Add PPB_Alarms_Dev interface definition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/generators/idl_c_header.py
diff --git a/ppapi/generators/idl_c_header.py b/ppapi/generators/idl_c_header.py
index a3b868874da14d8792a16f820e9dd1977ff77d4e..dd408d7936ac86572716c71dcd4c11ef976d24ed 100755
--- a/ppapi/generators/idl_c_header.py
+++ b/ppapi/generators/idl_c_header.py
@@ -145,9 +145,11 @@ def CheckTypedefs(filenode, releases):
See http://crbug.com/233439 for details.
"""
cgen = CGen()
- # TODO(teravest): Fix the following callback to pass PP_Var by pointer
- # instead of by value.
- node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1']
+ # TODO(yzshen): (1) remove PP_Ext_Alarms_OnAlarm_Func_Dev_0_1 and the
+ # corresponding whitelist entry; (2) fix this check -- it should be okay for
+ # PP_Alarms_OnAlarm_Dev to pass a struct pointer.
dmichael (off chromium) 2013/12/06 17:44:07 Have you checked with teravest or somebody on PNaC
yzshen1 2013/12/06 21:38:21 I could add Justin as a reviewer. This check was a
+ node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1',
+ 'PP_Alarms_OnAlarm_Dev']
for node in filenode.GetListOf('Typedef'):
if node.GetName() in node_whitelist:
continue

Powered by Google App Engine
This is Rietveld 408576698