Add PPB_Alarms_Dev interface definition.

ppapi/generators/idl_c_header.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Generator for C style prototypes and definitions """
 
 import glob
 import os
 import re
@@ skipping 127 matching lines @@
   if last_group:
     out.Write(CommentLines(['*',' @}', '']) + '\n')
 
 
 def CheckTypedefs(filenode, releases):
   """Checks that typedefs don't specify callbacks that take some structs.
 
   See http://crbug.com/233439 for details.
   """
   cgen = CGen()
-  # TODO(teravest): Fix the following callback to pass PP_Var by pointer
-  # instead of by value.
-  node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1']
+  # TODO(yzshen): (1) remove PP_Ext_Alarms_OnAlarm_Func_Dev_0_1 and the
+  # corresponding whitelist entry; (2) fix this check -- it should be okay for
+  # PP_Alarms_OnAlarm_Dev to pass a struct pointer.

[dmichael (off chromium), 2013/12/06 17:44:07]

Have you checked with teravest or somebody on PNaCl? This restriction has to do
with the PNaCl shim, and I don't remember the details.

[yzshen1, 2013/12/06 21:38:21]

I could add Justin as a reviewer.
This check was added to prevent us from adding more pass-by-value structs.

+  node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1',
+                    'PP_Alarms_OnAlarm_Dev']
   for node in filenode.GetListOf('Typedef'):
     if node.GetName() in node_whitelist:
       continue
     build_list = node.GetUniqueReleases(releases)
     callnode = node.GetOneOf('Callspec')
     if callnode:
       for param in callnode.GetListOf('Param'):
         if param.GetListOf('Array'):
           continue
         if cgen.GetParamMode(param) != 'in':
@@ skipping 185 matching lines @@
     print "Golden file for M13-M15 failed."
     failed =1
   else:
     print "Golden file for M13-M15 passed."
 
   return failed
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))