Chromium Code Reviews| Index: ppapi/generators/idl_c_header.py |
| diff --git a/ppapi/generators/idl_c_header.py b/ppapi/generators/idl_c_header.py |
| index a3b868874da14d8792a16f820e9dd1977ff77d4e..dd408d7936ac86572716c71dcd4c11ef976d24ed 100755 |
| --- a/ppapi/generators/idl_c_header.py |
| +++ b/ppapi/generators/idl_c_header.py |
| @@ -145,9 +145,11 @@ def CheckTypedefs(filenode, releases): |
| See http://crbug.com/233439 for details. |
| """ |
| cgen = CGen() |
| - # TODO(teravest): Fix the following callback to pass PP_Var by pointer |
| - # instead of by value. |
| - node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1'] |
| + # TODO(yzshen): (1) remove PP_Ext_Alarms_OnAlarm_Func_Dev_0_1 and the |
| + # corresponding whitelist entry; (2) fix this check -- it should be okay for |
| + # PP_Alarms_OnAlarm_Dev to pass a struct pointer. |
|
dmichael (off chromium)
2013/12/06 17:44:07
Have you checked with teravest or somebody on PNaC
yzshen1
2013/12/06 21:38:21
I could add Justin as a reviewer.
This check was a
|
| + node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1', |
| + 'PP_Alarms_OnAlarm_Dev'] |
| for node in filenode.GetListOf('Typedef'): |
| if node.GetName() in node_whitelist: |
| continue |