Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: Source/modules/accessibility/AXObject.h

Issue 1039873002: AX presentation role should be inherited to its required owned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved code to AXNodeObject Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXObject.h
diff --git a/Source/modules/accessibility/AXObject.h b/Source/modules/accessibility/AXObject.h
index d350173eb883905019d3cbc3586fe10733b7a393..f65ed2124381b1bf5533c82aad678f488f98d809 100644
--- a/Source/modules/accessibility/AXObject.h
+++ b/Source/modules/accessibility/AXObject.h
@@ -622,6 +622,8 @@ public:
static const AtomicString& roleName(AccessibilityRole);
static bool isInsideFocusableElementOrARIAWidget(const Node&);
+ bool hasInheritedPresentationRole() const { return m_cachedHasInheritedPresentationRole; }
+
protected:
AXID m_id;
AccessibilityChildrenVector m_children;
@@ -631,6 +633,7 @@ protected:
LayoutRect m_explicitElementRect;
virtual bool computeAccessibilityIsIgnored() const { return true; }
+ virtual bool computeHasInheritedPresentationRole() const { return false; }
// If this object itself scrolls, return its ScrollableArea.
virtual ScrollableArea* getScrollableAreaIfScrollable() const { return 0; }
@@ -652,6 +655,7 @@ protected:
mutable bool m_cachedIsInertOrAriaHidden : 1;
mutable bool m_cachedIsDescendantOfBarrenParent : 1;
mutable bool m_cachedIsDescendantOfDisabledNode : 1;
+ mutable bool m_cachedHasInheritedPresentationRole : 1;
mutable const AXObject* m_cachedLiveRegionRoot;
AXObjectCacheImpl* m_axObjectCache;

Powered by Google App Engine
This is Rietveld 408576698