Source/modules/accessibility/AXObject.cpp - Issue 1039873002: AX presentation role should be inherited to its required owned elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXObject.cpp

Issue 1039873002: AX presentation role should be inherited to its required owned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Moved code to AXNodeObject Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXObject.cpp

diff --git a/Source/modules/accessibility/AXObject.cpp b/Source/modules/accessibility/AXObject.cpp

index 156dba1ab217ab00e6a7cf8e25151313d79b35f0..433f388b6b5746eb949d95e9367536f434edad06 100644

--- a/Source/modules/accessibility/AXObject.cpp

+++ b/Source/modules/accessibility/AXObject.cpp

@@ -236,6 +236,7 @@ AXObject::AXObject(AXObjectCacheImpl* axObjectCache)

, m_cachedIsInertOrAriaHidden(false)

, m_cachedIsDescendantOfBarrenParent(false)

, m_cachedIsDescendantOfDisabledNode(false)

+ , m_cachedHasInheritedPresentationRole(false)

, m_cachedLiveRegionRoot(0)

, m_axObjectCache(axObjectCache)

{

@@ -370,6 +371,7 @@ void AXObject::updateCachedAttributeValuesIfNeeded() const

m_cachedIsInertOrAriaHidden = computeIsInertOrAriaHidden();

m_cachedIsDescendantOfBarrenParent = computeIsDescendantOfBarrenParent();

m_cachedIsDescendantOfDisabledNode = computeIsDescendantOfDisabledNode();

+ m_cachedHasInheritedPresentationRole = computeHasInheritedPresentationRole();

m_cachedIsIgnored = computeAccessibilityIsIgnored();

m_cachedLiveRegionRoot = isLiveRegion() ?

this :

« Source/modules/accessibility/AXNodeObject.cpp ('K') | « Source/modules/accessibility/AXObject.h ('k') | no next file » | no next file with comments »