Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1039853003: Revert "Compile quic_server on MacOS" (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Compile quic_server on MacOS" This reverts commit e0f2b8f00e9a70285f25c42d4ab9612b0e0013ca Original review https://codereview.chromium.org/994193002 Committed: https://crrev.com/6983a3f9c5b228716e6b6ee1c477cfa1a42472a4 Cr-Commit-Position: refs/heads/master@{#322736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -8 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_socket_utils.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ryan Hamilton
5 years, 9 months ago (2015-03-28 03:13:34 UTC) #2
dougk
lgtm
5 years, 9 months ago (2015-03-28 14:48:03 UTC) #3
Ryan Hamilton
5 years, 9 months ago (2015-03-28 18:53:58 UTC) #5
ramant (doing other things)
lgtm
5 years, 8 months ago (2015-03-30 00:43:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039853003/1
5 years, 8 months ago (2015-03-30 03:24:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 03:47:38 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 03:48:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6983a3f9c5b228716e6b6ee1c477cfa1a42472a4
Cr-Commit-Position: refs/heads/master@{#322736}

Powered by Google App Engine
This is Rietveld 408576698