Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 103963007: win ninja: default to embedding manifest to match msvs (Closed)

Created:
7 years ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

win ninja: default to embedding manifest to match msvs And add a test for this specific variation. R=thakis@chromium.org BUG=chromium:326030 Committed: https://code.google.com/p/gyp/source/detail?r=1814

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pylib/gyp/msvs_emulation.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/win/gyptest-link-generate-manifest.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/win/linker-flags/generate-manifest.gyp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
7 years ago (2013-12-11 21:29:45 UTC) #1
scottmg
[[[ 3 yaks deep in making binaries match: - The Windows failures here (undesireably relinking) ...
7 years ago (2013-12-11 23:01:55 UTC) #2
Nico
lgtm https://codereview.chromium.org/111373002/ is cool
7 years ago (2013-12-12 17:46:23 UTC) #3
scottmg
Committed patchset #2 manually as r1814 (presubmit successful).
7 years ago (2013-12-12 21:54:36 UTC) #4
Nico
This test flakily failed at http://build.chromium.org/p/tryserver.nacl/builders/gyp-win64/builds/1520 – maybe it needs a test.sleep() somewhere?
6 years, 11 months ago (2013-12-26 18:14:01 UTC) #5
scottmg
6 years, 11 months ago (2014-01-06 16:57:27 UTC) #6
Message was sent while issue was closed.
On 2013/12/26 18:14:01, Nico wrote:
> This test flakily failed at
> http://build.chromium.org/p/tryserver.nacl/builders/gyp-win64/builds/1520 –
> maybe it needs a test.sleep() somewhere?

Thanks. Strange, it doesn't seem like it should need a sleep anywhere. Maybe
there's a dependency problem somewhere...

Powered by Google App Engine
This is Rietveld 408576698