pylib/gyp/msvs_emulation.py - Issue 103963007: win ninja: default to embedding manifest to match msvs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/msvs_emulation.py

Issue 103963007: win ninja: default to embedding manifest to match msvs (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/msvs_emulation.py

diff --git a/pylib/gyp/msvs_emulation.py b/pylib/gyp/msvs_emulation.py

index a9f65a128c500008ad5f59711eff81f140a6201b..92ea86b7a5bcb372c422a607a1959465e8d216fe 100644

--- a/pylib/gyp/msvs_emulation.py

+++ b/pylib/gyp/msvs_emulation.py

@@ -645,7 +645,8 @@ class MsvsSettings(object):

def IsEmbedManifest(self, config):

"""Returns whether manifest should be linked into binary."""

config = self._TargetConfig(config)

- embed = self._Setting(('VCManifestTool', 'EmbedManifest'), config)

+ embed = self._Setting(('VCManifestTool', 'EmbedManifest'), config,

+ default='true')

return embed == 'true'

def IsLinkIncremental(self, config):

« no previous file with comments | « no previous file | test/win/gyptest-link-generate-manifest.py » ('j') | no next file with comments »