Issue 1039603004: Fix FileSpan.context to include FileSpan.text.

Issue 1039603004: Fix FileSpan.context to include FileSpan.text. (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
5 years, 9 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/source_span.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix FileSpan.context to include FileSpan.text. R=nweiz@google.com Committed: https://github.com/dart-lang/source_span/commit/d76e9806e53973aa232c97d468dca601f80d8a82

Patch Set 2 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
M	CHANGELOG.md	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/file.dart	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/file_test.dart	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nweiz

lgtm https://codereview.chromium.org/1039603004/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1039603004/diff/20001/CHANGELOG.md#newcode1 CHANGELOG.md:1: # 1.1.0+1 1.1.1. Since this is post-1.0.0, we ...

5 years, 9 months ago (2015-03-27 19:58:42 UTC) #4

Siggi Cherem (dart-lang)

Committed patchset #2 (id:40001) manually as d76e9806e53973aa232c97d468dca601f80d8a82 (presubmit successful).

5 years, 9 months ago (2015-03-27 21:25:01 UTC) #5

Siggi Cherem (dart-lang)

5 years, 9 months ago (2015-03-27 21:26:09 UTC) #6

Message was sent while issue was closed.

thanks

https://codereview.chromium.org/1039603004/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1039603004/diff/20001/CHANGELOG.md#newcode1
CHANGELOG.md:1: # 1.1.0+1
On 2015/03/27 19:58:42, nweiz wrote:
> 1.1.1. Since this is post-1.0.0, we don't use build identifiers anymore.

Done.

https://codereview.chromium.org/1039603004/diff/20001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1039603004/diff/20001/pubspec.yaml#newcode2
pubspec.yaml:2: version: 1.1.0+1
On 2015/03/27 19:58:42, nweiz wrote:
> Also 1.1.1.

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages