Chromium Code Reviews Chromium Code Reviews
Issue 1039603004:
Fix FileSpan.context to include FileSpan.text. (Closed)
Base URL: git@github.com:dart-lang/source_span.git@master| OLD | NEW |
|---|---|
| 1 # 1.1.0+1 | |
|
nweiz
2015/03/27 19:58:42
1.1.1. Since this is post-1.0.0, we don't use buil
Siggi Cherem (dart-lang)
2015/03/27 21:26:09
Done.
| |
| 2 | |
| 3 * Fixed `FileSpan`'s context to include the full span text, not just the first | |
| 4 line of it. | |
| 5 | |
| 1 # 1.1.0 | 6 # 1.1.0 |
| 2 | 7 |
| 3 * Added `SourceSpanWithContext`: a span that also includes the full line of text | 8 * Added `SourceSpanWithContext`: a span that also includes the full line of text |
| 4 that contains the span. | 9 that contains the span. |
| 5 | 10 |
| 6 # 1.0.3 | 11 # 1.0.3 |
| 7 | 12 |
| 8 * Cleanup equality operator to accept any Object rather than just a | 13 * Cleanup equality operator to accept any Object rather than just a |
| 9 `SourceLocation`. | 14 `SourceLocation`. |
| 10 | 15 |
| (...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 45 `SourceSpan.message` and `SourceFile.message`, respectively. Rather than | 50 `SourceSpan.message` and `SourceFile.message`, respectively. Rather than |
| 46 taking both a `useColor` and a `color` parameter, they now take a single | 51 taking both a `useColor` and a `color` parameter, they now take a single |
| 47 `color` parameter that controls both whether and which color is used. | 52 `color` parameter that controls both whether and which color is used. |
| 48 | 53 |
| 49 * `Span.isIdentifier` has been removed. This property doesn't make sense outside | 54 * `Span.isIdentifier` has been removed. This property doesn't make sense outside |
| 50 of a source map context. | 55 of a source map context. |
| 51 | 56 |
| 52 * `SourceFileSegment` has been removed. This class wasn't widely used and was | 57 * `SourceFileSegment` has been removed. This class wasn't widely used and was |
| 53 inconsistent in its choice of which parameters were considered relative and | 58 inconsistent in its choice of which parameters were considered relative and |
| 54 which absolute. | 59 which absolute. |
| OLD | NEW |
