Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1039233002: Defer waiting for child account status until it is actually used. (Closed)

Created:
5 years, 8 months ago by knn
Modified:
5 years, 8 months ago
Reviewers:
Marc Treib, Yaron
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Defer waiting for child account status until it is actually used. BUG=471229 Committed: https://crrev.com/1c4490751fe526a9a4abd97dd65e24b649c950e4 Cr-Commit-Position: refs/heads/master@{#322586}

Patch Set 1 #

Patch Set 2 : Revert re-enabling child account finch flag. Defer to a separate issue #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java View 2 chunks +1 line, -5 lines 2 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
knn
PTAL. This is for trunk and unrelated to the M42 crash.
5 years, 8 months ago (2015-03-27 14:12:48 UTC) #2
Yaron
https://codereview.chromium.org/1039233002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java File chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java (right): https://codereview.chromium.org/1039233002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java#newcode181 chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java:181: ChildAccountService.getInstance(context).checkHasChildAccount( I'm confused. Doesn't this still has to be ...
5 years, 8 months ago (2015-03-27 14:24:32 UTC) #3
Marc Treib
LGTM (but once again, I don't own anything here)
5 years, 8 months ago (2015-03-27 14:26:25 UTC) #4
knn
https://codereview.chromium.org/1039233002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java File chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java (right): https://codereview.chromium.org/1039233002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java#newcode181 chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java:181: ChildAccountService.getInstance(context).checkHasChildAccount( On 2015/03/27 14:24:32, Yaron wrote: > I'm confused. ...
5 years, 8 months ago (2015-03-27 14:33:20 UTC) #5
Yaron
lgtm
5 years, 8 months ago (2015-03-27 15:39:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039233002/20001
5 years, 8 months ago (2015-03-27 15:47:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-27 16:10:27 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 16:11:01 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c4490751fe526a9a4abd97dd65e24b649c950e4
Cr-Commit-Position: refs/heads/master@{#322586}

Powered by Google App Engine
This is Rietveld 408576698