Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java

Issue 1039233002: Defer waiting for child account status until it is actually used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert re-enabling child account finch flag. Defer to a separate issue Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
index 53cad1c3b33c70fb204410ed3c43b4012f808e21..574417c8032692d8062b499fa455e0107dddc5ac 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
@@ -178,9 +178,7 @@ public abstract class ChromiumApplication extends ContentApplication {
public Integer call() {
try {
// Kick off checking for a child account with an empty callback.
- ChildAccountService childAccountService =
- ChildAccountService.getInstance(context);
- childAccountService.checkHasChildAccount(
+ ChildAccountService.getInstance(context).checkHasChildAccount(
Yaron 2015/03/27 14:24:32 I'm confused. Doesn't this still has to be after t
knn 2015/03/27 14:33:20 Sorry I forgot to replicate issue description from
new ChildAccountService.HasChildAccountCallback() {
@Override
public void onChildAccountChecked(boolean hasChildAccount) {
@@ -189,8 +187,6 @@ public abstract class ChromiumApplication extends ContentApplication {
BrowserStartupController.get(context, LibraryProcessType.PROCESS_BROWSER)
.startBrowserProcessesSync(false);
if (initGoogleServicesManager) initializeGoogleServicesManager();
- // Wait until ChildAccountManager finishes its check.
- childAccountService.waitUntilFinished();
return LoaderErrors.LOADER_ERROR_NORMAL_COMPLETION;
} catch (ProcessInitException e) {
Log.e(TAG, "Unable to load native library.", e);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698