doc.external - Check direction of property access before blindly getting.

fpdfsdk/src/javascript/Document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 1121 matching lines @@
                 sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
                 return FALSE;
         }
         vp << m_pDocument->GetPageCount();
         return TRUE;
 }
 
 FX_BOOL Document::external(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         //In Chrome case,should always return true.
-        vp << TRUE;
+        if (vp.IsGetting()) {
+                vp << TRUE;
+        }
         return TRUE;
 }
 
 FX_BOOL Document::filesize(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsSetting()) {
                 CJS_Context* pContext = static_cast<CJS_Context*>(cc);
                 sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
                 return FALSE;
         }
         vp << 0;
         return TRUE;
 }
 
 FX_BOOL Document::mouseX(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL Document::mouseY(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL Document::baseURL(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsGetting())
         {
                 vp << m_cwBaseURL;
-                return TRUE;
         }
         else
         {
                 vp >> m_cwBaseURL;
-                return TRUE;
         }
+        return TRUE;
 }
 
 FX_BOOL Document::calculate(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
 
         CPDFSDK_InterForm* pInterForm = (CPDFSDK_InterForm*)m_pDocument->GetInterForm();
         ASSERT(pInterForm != NULL);
 
         if (vp.IsGetting())
@@ skipping 106 matching lines @@
 }
 
 FX_BOOL Document::addLink(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL Document::closeDoc(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
-
-
-
-
-
         return TRUE;
 }
 
 FX_BOOL Document::getPageBox(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return TRUE;
 }
 
-
 FX_BOOL Document::getAnnot(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL Document::getAnnots(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         vRet.SetNull();
         return TRUE;
 }
@@ skipping 616 matching lines @@
 
 void Document::DoAnnotDelay()
 {
         CFX_DWordArray DelArray;
 
         for (int j=DelArray.GetSize()-1; j>=0; j--)
         {
                 m_DelayData.RemoveAt(DelArray[j]);
         }
 }