Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1039023002: AX nodes that aren't contenteditable should be readonly. (Closed)

Created:
5 years, 9 months ago by dmazzoni
Modified:
5 years, 8 months ago
Reviewers:
je_julie(Not used)
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@listboxes_too
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

AX nodes that aren't contenteditable should be readonly. We were returning the wrong result from AXObjects that did not descend from AXNodeObject. BUG=471075 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192906

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M LayoutTests/accessibility/readonly.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/accessibility/readonly-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
5 years, 8 months ago (2015-03-31 20:08:50 UTC) #2
je_julie(Not used)
lgtm
5 years, 8 months ago (2015-04-01 01:08:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039023002/20001
5 years, 8 months ago (2015-04-01 04:14:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192906
5 years, 8 months ago (2015-04-01 05:13:55 UTC) #6
hayato
5 years, 8 months ago (2015-04-01 09:33:06 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1052603002/ by hayato@chromium.org.

The reason for reverting is: Blink gardening. The following tests are failing on
Win7 after this CL.

DumpAccessibilityTreeTest.AccessibilityAriaColumnHeader
DumpAccessibilityTreeTest.AccessibilityAriaGrid
DumpAccessibilityTreeTest.AccessibilityAriaGridCell
DumpAccessibilityTreeTest.AccessibilityAriaLevel
DumpAccessibilityTreeTest.AccessibilityAriaOrientation
DumpAccessibilityTreeTest.AccessibilityAriaRow
DumpAccessibilityTreeTest.AccessibilityAriaRowGroup
DumpAccessibilityTreeTest.AccessibilityAriaRowHeader
DumpAccessibilityTreeTest.AccessibilityAriaSortOnAriaGrid
DumpAccessibilityTreeTest.AccessibilityAriaSortOnHtmlTable
DumpAccessibilityTreeTest.AccessibilityAriaTreeGrid
DumpAccessibilityTreeTest.AccessibilityCaption
DumpAccessibilityTreeTest.AccessibilityContenteditableDescendants
DumpAccessibilityTreeTest.AccessibilityIframe
DumpAccessibilityTreeTest.AccessibilityIframePresentational
DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeClosed
DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeOpened

Build log:
https://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/9222

Sheriff-o-matic says the blink range is 192906:192906.
.

Powered by Google App Engine
This is Rietveld 408576698