Source/modules/accessibility/AXObject.cpp - Issue 1039023002: AX nodes that aren't contenteditable should be readonly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXObject.cpp

Issue 1039023002: AX nodes that aren't contenteditable should be readonly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@listboxes_too

Patch Set: Add test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXObject.cpp

diff --git a/Source/modules/accessibility/AXObject.cpp b/Source/modules/accessibility/AXObject.cpp

index f5cd5277653bcf7d39b8ee6be823cef3b425d883..0e3b3f1f77e26ca4357fb1b721fce84506311ce8 100644

--- a/Source/modules/accessibility/AXObject.cpp

+++ b/Source/modules/accessibility/AXObject.cpp

@@ -350,6 +350,14 @@ bool AXObject::isClickable() const

}

+bool AXObject::isReadOnly() const

+ if (node())

+ return !node()->hasEditableStyle();

+ return true;

bool AXObject::accessibilityIsIgnored() const

{

updateCachedAttributeValuesIfNeeded();

« no previous file with comments | « Source/modules/accessibility/AXObject.h ('k') | no next file » | no next file with comments »