Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 1038763005: Service Worker: Reset "idle" timer upon completion of an event. (Closed)

Created:
5 years, 9 months ago by falken
Modified:
5 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Service Worker: Reset "idle" timer upon completion of an event. Otherwise the worker could get stopped if the timer happens to expire between events while it's in a flurry of events. BUG=462096 Committed: https://crrev.com/17f72bbde1bef95b10c2c56ced278a33dd74c05a Cr-Commit-Position: refs/heads/master@{#322341}

Patch Set 1 #

Patch Set 2 : reliably test timer being reset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M content/browser/service_worker/service_worker_version.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 4 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
falken
PTL
5 years, 9 months ago (2015-03-26 04:50:04 UTC) #2
kinuko
lgtm, thanks for fixing this!
5 years, 9 months ago (2015-03-26 05:01:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038763005/1
5 years, 9 months ago (2015-03-26 05:08:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/41691)
5 years, 9 months ago (2015-03-26 06:30:36 UTC) #7
falken
On 2015/03/26 06:30:36, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-26 07:22:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038763005/20001
5 years, 9 months ago (2015-03-26 08:16:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 09:22:06 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 09:22:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17f72bbde1bef95b10c2c56ced278a33dd74c05a
Cr-Commit-Position: refs/heads/master@{#322341}

Powered by Google App Engine
This is Rietveld 408576698