content/browser/service_worker/service_worker_version.cc - Issue 1038763005: Service Worker: Reset "idle" timer upon completion of an event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1038763005: Service Worker: Reset "idle" timer upon completion of an event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reliably test timer being reset Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/browser/service_worker/service_worker_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index 1457ed7a49049631d0e40dd332f669e0f1120878..8d49bf0d7395ce7c39e6ccda3223420d826f6740 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -1693,6 +1693,7 @@ template <typename IDMAP>

void ServiceWorkerVersion::RemoveCallbackAndStopIfDoomed(

IDMAP* callbacks,

int request_id) {

+ RestartTick(&idle_time_);

callbacks->Remove(request_id);

if (is_doomed_) {

// The stop should be already scheduled, but try to stop immediately, in