Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1038723002: Reland part 3 of 4: Modify blink users so they use blink images. (Closed)

Created:
5 years, 9 months ago by Elliot Glaysher
Modified:
5 years, 8 months ago
Reviewers:
tapted, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, extensions-reviews_chromium.org, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, ben+mojo_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland part 3 of 4: Modify blink users so they use blink images. Now that the image resources that blink depends on are in the blink repository, we depend on the blink resources directly, delete the ones in the chrome tree, and use these resources in the html_viewer. [This reland also contains a fix to the generate_blink_resource_map.py file so that its generated code uses unsigned chars, which should hopefully fix the Win8 gn bot.] BUG=467176 First Review URL: https://codereview.chromium.org/1033733004 Committed: https://crrev.com/db167e36fd2b1a4b4492c70ee246c1ff795bfcb4 Cr-Commit-Position: refs/heads/master@{#322427}

Patch Set 1 #

Patch Set 2 : Use 'const unsigned char' for resources. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -124 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +1 line, -0 lines 1 comment Download
M chrome/chrome_repack_resources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/app/resources/content_resources.grd View 2 chunks +0 lines, -48 lines 0 comments Download
D content/app/resources/default_100_percent/broken_image.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_cast_off.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_cast_on.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_closedcaption.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_closedcaption_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_closedcaption_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_closedcaption_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_fullscreen.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_fullscreen_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_fullscreen_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_fullscreen_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_overlay_cast_off.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_overlay_play.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_pause.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_pause_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_pause_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_play.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_play_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_play_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_play_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_slider_thumb.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_slider_thumb_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_slider_thumb_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level0.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level0_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level0_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level1.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level1_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level1_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level2.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level2_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level2_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level3.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level3_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level3_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_volume_slider_thumb.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_volume_slider_thumb_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_volume_slider_thumb_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_volume_slider_thumb_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pan_icon.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/password_generation.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/password_generation_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/search_cancel.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/search_cancel_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/search_magnifier.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/search_magnifier_results.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/textarea_resize_corner.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/broken_image.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pan_icon.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/textarea_resize_corner.png View Binary file 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +50 lines, -50 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/common/shell_content_client.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/blink_resource_constants.h View 1 chunk +56 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/generate_blink_resource_map.py View 1 5 chunks +5 lines, -10 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Elliot Glaysher
Patch 2 has the fix.
5 years, 9 months ago (2015-03-25 21:13:34 UTC) #2
jam
lgtm
5 years, 8 months ago (2015-03-26 15:41:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038723002/20001
5 years, 8 months ago (2015-03-26 17:05:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-26 18:22:02 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/db167e36fd2b1a4b4492c70ee246c1ff795bfcb4 Cr-Commit-Position: refs/heads/master@{#322427}
5 years, 8 months ago (2015-03-26 18:23:05 UTC) #7
tapted
5 years, 8 months ago (2015-03-30 01:45:09 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1038723002/diff/20001/chrome/chrome_repack_ch...
File chrome/chrome_repack_chrome_200_percent.gypi (right):

https://codereview.chromium.org/1038723002/diff/20001/chrome/chrome_repack_ch...
chrome/chrome_repack_chrome_200_percent.gypi:18:
'<(SHARED_INTERMEDIATE_DIR)/blink/public/resources/blink_resources_200_percent.pak',
So this line accounts for about 1MB of the 1.5MB sizes regression on Mac in
http://crbug.com/471609 (i.e. deleting this line and rebuilding, Google\
Chrome.app goes from 179152kB to 178136kB

I think this must be a packaging error. WebKit/public/default_200_percent/blink
has only 1kB of resources but this 200_percent.pak file is full of js/css and
(looking at blink_resources.grd) a bunch of .wav files? There are now two copies
of all of these being bundled into Chromium.app on Mac.

Powered by Google App Engine
This is Rietveld 408576698