Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1033733004: Part 3 of 4: Modify blink users so they use the image resources in blink. (Closed)

Created:
5 years, 9 months ago by Elliot Glaysher
Modified:
5 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, extensions-reviews_chromium.org, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, ben+mojo_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Part 3 of 4: Modify blink users so they use the image resources in blink. Now that the image resources that blink depends on are in the blink repository, we depend on the blink resources directly, delete the ones in the chrome tree, and use these resources in the html_viewer. BUG=467176 Committed: https://crrev.com/ebbf3c1bf5f41b0133657515302e3b110abedee1 Cr-Commit-Position: refs/heads/master@{#322201}

Patch Set 1 #

Patch Set 2 : Maybe fix the build. #

Patch Set 3 : Fix 100/200 percent packs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -117 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/app/resources/content_resources.grd View 2 chunks +0 lines, -48 lines 0 comments Download
D content/app/resources/default_100_percent/broken_image.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_cast_off.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_cast_on.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_closedcaption.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_closedcaption_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_closedcaption_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_closedcaption_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_fullscreen.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_fullscreen_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_fullscreen_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_fullscreen_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_overlay_cast_off.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_overlay_play.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_pause.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_pause_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_pause_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_play.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_play_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_play_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_play_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_slider_thumb.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_slider_thumb_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_slider_thumb_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level0.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level0_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level0_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level1.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level1_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level1_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level2.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level2_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level2_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level3.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level3_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_sound_level3_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_volume_slider_thumb.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_volume_slider_thumb_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_volume_slider_thumb_down.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/mediaplayer_volume_slider_thumb_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pan_icon.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/password_generation.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/password_generation_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/search_cancel.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/search_cancel_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/search_magnifier.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/search_magnifier_results.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/textarea_resize_corner.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/broken_image.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pan_icon.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/textarea_resize_corner.png View Binary file 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +50 lines, -50 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/common/shell_content_client.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/html_viewer/blink_resource_constants.h View 1 chunk +56 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/generate_blink_resource_map.py View 2 chunks +0 lines, -5 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
5 years, 9 months ago (2015-03-25 00:23:43 UTC) #2
jam
lgtm
5 years, 9 months ago (2015-03-25 16:35:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033733004/40001
5 years, 9 months ago (2015-03-25 17:12:40 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-25 19:05:00 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:05:54 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ebbf3c1bf5f41b0133657515302e3b110abedee1
Cr-Commit-Position: refs/heads/master@{#322201}

Powered by Google App Engine
This is Rietveld 408576698