Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 1038713002: Make 'Linux deterministic build' green. (Closed)

Created:
5 years, 9 months ago by M-A Ruel
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, Derek Schuff, JF, jvoung (off chromium), kjellander-cc_chromium.org, Roland McGrath, Mark Seaborn, Nick Bray (chromium), Petr Hosek, stip+watch_chromium.org, teravest, Yoshisato Yanagisawa
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Make 'Linux deterministic build' green. It's currently red due to 3 files, which affects one fourth isolated file. The files are all pnacl related. R=sebmarchand@chromium.org BUG=330263 BUG=429358 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294569

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
M-A Ruel
cc'ing people on issue #429358 FYI. Example failure: http://build.chromium.org/p/chromium.swarm/builders/Linux%20deterministic%20build/builds/6573/steps/compare_build_artifacts/logs/stdio --- CUT HERE --- base_unittests : ...
5 years, 9 months ago (2015-03-25 18:05:15 UTC) #2
Sébastien Marchand
lgtm.
5 years, 9 months ago (2015-03-25 18:32:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038713002/20001
5 years, 9 months ago (2015-03-25 18:32:49 UTC) #5
commit-bot: I haz the power
Presubmit check for 1038713002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-03-25 18:34:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038713002/20001
5 years, 9 months ago (2015-03-25 18:37:32 UTC) #9
commit-bot: I haz the power
Presubmit check for 1038713002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-03-25 18:39:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038713002/20001
5 years, 9 months ago (2015-03-25 19:30:58 UTC) #13
commit-bot: I haz the power
Presubmit check for 1038713002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-03-25 19:33:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038713002/20001
5 years, 9 months ago (2015-03-25 20:23:54 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 20:26:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294569

Powered by Google App Engine
This is Rietveld 408576698