Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

Issue 1038713002: Make 'Linux deterministic build' green. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py
diff --git a/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py b/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py
index 670864fffed0046889461b5ebb64a157378d9244..903d754277bd60d485e32b4bef23d794da0c68d8 100755
--- a/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py
+++ b/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py
@@ -18,8 +18,11 @@ from infra.libs.infra_types import freeze
BASE_DIR = os.path.dirname(os.path.abspath(__file__))
-# List of files that are known to be non deterministic. This is a temporary
+# List of files that are known to be non deterministic. This is a "temporary"
# workaround to find regression on the deterministic builders.
+#
+# PNaCl general bug: http://crbug.com/429358
+#
# TODO(sebmarchand): Remove this once all the files are deterministic.
WHITELIST = freeze({
# http://crbug.com/383340
@@ -34,7 +37,10 @@ WHITELIST = freeze({
# http://crbug.com/330263
'linux': {
- # Completed.
+ 'browser_tests.isolated',
+ 'irt_exception_test_pnacl_newlib_x64.nexe',
+ 'irt_manifest_file_pnacl_newlib_x64.nexe',
+ 'ppapi_tests_extensions_packaged_app_pnacl_newlib_x64.nexe',
},
# http://crbug.com/330262
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698