Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1038533002: Load data for StocksApp incrementally (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Load data for StocksApp incrementally Previously we would spend a lot of time during startup processing all 3k stocks in the data set. This CL breaks the data up into 100 stock chunks and loads them incrementally off the network. A future CL will switch to loading them on demand. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f7a9c3fdb87a80dbf92fd88a3e2b801eae642b9c

Patch Set 1 #

Patch Set 2 : remove spurious diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29724 lines, -2994 lines) Patch
A sky/examples/stocks-fn/data/stock_data_0.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_1.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_10.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_11.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_12.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_13.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_14.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_15.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_16.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_17.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_18.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_19.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_2.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_20.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_21.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_22.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_23.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_24.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_25.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_26.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_27.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_28.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_29.json View 1 1 chunk +632 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_3.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_4.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_5.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_6.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_7.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_8.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
A sky/examples/stocks-fn/data/stock_data_9.json View 1 1 chunk +1002 lines, -0 lines 0 comments Download
M sky/examples/stocks-fn/lib/stock_app.dart View 1 2 chunks +5 lines, -7 lines 0 comments Download
M sky/examples/stocks-fn/lib/stock_data.dart View 1 2 chunks +29 lines, -22 lines 0 comments Download
D sky/examples/stocks-fn/lib/stock_data.json View 1 1 chunk +0 lines, -2965 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-24 21:38:36 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-24 21:50:29 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-24 21:58:49 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) manually as
f7a9c3fdb87a80dbf92fd88a3e2b801eae642b9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698