ninja windows: support msvs_quote_cmd support

The msvs generator has a setting 'msvs_quote_cmd' that when set to 0 suppresses all quote/shell escaping when running actions.

It seems a bit questionable, but as some Chromium actions rely on being able to do this, support the same behaviour in ninja.

Add test for this setting for msvs and ninja.

BUG=127444

[scottmg, 2012-05-10 17:56:52]

add test for msvs_quote_cmd

[Nico, 2012-05-10 19:04:22]

Looks good except for the crash-on-non-windows (if I didn't just misread the
code)

https://chromiumcodereview.appspot.com/10384100/diff/2001/pylib/gyp/generator...
File pylib/gyp/generator/ninja.py (right):

https://chromiumcodereview.appspot.com/10384100/diff/2001/pylib/gyp/generator...
pylib/gyp/generator/ninja.py:552: if win_shell_flags.cygwin:
As far as I can tell, cygwin_munge is called on non-windows too. Since
win_shell_flags is None there, this line will always throw on non-win.

https://chromiumcodereview.appspot.com/10384100/diff/2001/test/win/no-quoting...
File test/win/no-quoting/no-quoting.gyp (right):

https://chromiumcodereview.appspot.com/10384100/diff/2001/test/win/no-quoting...
test/win/no-quoting/no-quoting.gyp:34: },
Is noquote + cygwin shell something that's interesting to test?

[scottmg, 2012-05-10 19:46:48]

fixes

[scottmg, 2012-05-10 19:47:00]

http://chromiumcodereview.appspot.com/10384100/diff/2001/pylib/gyp/generator/...
File pylib/gyp/generator/ninja.py (right):

http://chromiumcodereview.appspot.com/10384100/diff/2001/pylib/gyp/generator/...
pylib/gyp/generator/ninja.py:552: if win_shell_flags.cygwin:
On 2012/05/10 19:04:22, Nico wrote:
> As far as I can tell, cygwin_munge is called on non-windows too. Since
> win_shell_flags is None there, this line will always throw on non-win.

Thanks, done.

http://chromiumcodereview.appspot.com/10384100/diff/2001/test/win/no-quoting/...
File test/win/no-quoting/no-quoting.gyp (right):

http://chromiumcodereview.appspot.com/10384100/diff/2001/test/win/no-quoting/...
test/win/no-quoting/no-quoting.gyp:34: },
On 2012/05/10 19:04:22, Nico wrote:
> Is noquote + cygwin shell something that's interesting to test?

It appears to be ignored in msvs.py when in cygwin mode. I dunno... doesn't seem
too useful to test that. But, I think I'll add an assert that if msvs_quote_cmd
= 0 that msvs_cygwin_shell is also 0.

[Nico, 2012-05-10 21:20:57]

lgtm

http://chromiumcodereview.appspot.com/10384100/diff/8001/pylib/gyp/msvs_emula...
File pylib/gyp/msvs_emulation.py (right):

http://chromiumcodereview.appspot.com/10384100/diff/8001/pylib/gyp/msvs_emula...
pylib/gyp/msvs_emulation.py:412: self.quote = quote
Since we're on python2.6+ everywhere, you could use collections.namedtuple
instead of this class if you want. (You need to move the assert to
GetRuleShellFlags() in that case.)

[scottmg, 2012-05-10 21:42:24]

use namedtuple instead

[scottmg, 2012-05-23 16:36:51]

closing, in favor of deprecating the msvs_quote_cmd 'feature' at a later date.