Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1038283003: Finalize sweeping in idle notification when all pages are swept. (Closed)

Created:
5 years, 8 months ago by Hannes Payer (out of office)
Modified:
5 years, 8 months ago
Reviewers:
ulan, rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Finalize sweeping in idle notification when all pages are swept. A follow-up CL will implement incremental sweeping during idle time. BUG= Committed: https://crrev.com/eda9a88f2f941d4ef84f2e48e5309b5ab156d7af Cr-Commit-Position: refs/heads/master@{#27513}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 8 months ago (2015-03-30 09:22:38 UTC) #2
ulan
lgtm
5 years, 8 months ago (2015-03-30 09:43:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038283003/60001
5 years, 8 months ago (2015-03-30 09:44:02 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-03-30 10:05:29 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/eda9a88f2f941d4ef84f2e48e5309b5ab156d7af Cr-Commit-Position: refs/heads/master@{#27513}
5 years, 8 months ago (2015-03-30 10:05:44 UTC) #7
rmcilroy
5 years, 8 months ago (2015-03-30 10:08:59 UTC) #8
Message was sent while issue was closed. 
On 2015/03/30 10:05:44, I haz the power (commit-bot) wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/eda9a88f2f941d4ef84f2e48e5309b5ab156d7af
> Cr-Commit-Position: refs/heads/master@{#27513}

nice, lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698