Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1037863003: MIPS64: [turbofan] Fix loading of JSFunction from activation in case of adapter frame. (Closed)

Created:
5 years, 9 months ago by paul.l...
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: [turbofan] Fix loading of JSFunction from activation in case of adapter frame. Use 64-bit load. BUG= Committed: https://crrev.com/ab027aeac386406ededc0db7e9f645a7dfd29de1 Cr-Commit-Position: refs/heads/master@{#27489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
paul.l...
PTAL. In addition to this, there are two more OSR errors on mips64 to be ...
5 years, 9 months ago (2015-03-26 01:37:13 UTC) #2
titzer
lgtm
5 years, 9 months ago (2015-03-26 07:53:34 UTC) #3
titzer
On 2015/03/26 01:37:13, paul.l... wrote: > PTAL. In addition to this, there are two more ...
5 years, 9 months ago (2015-03-26 09:10:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037863003/1
5 years, 9 months ago (2015-03-26 22:27:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 22:51:01 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ab027aeac386406ededc0db7e9f645a7dfd29de1 Cr-Commit-Position: refs/heads/master@{#27489}
5 years, 9 months ago (2015-03-26 22:51:07 UTC) #8
paul.l...
5 years, 9 months ago (2015-03-27 02:16:36 UTC) #9
Message was sent while issue was closed.
On 2015/03/26 09:10:44, titzer wrote:
> On 2015/03/26 01:37:13, paul.l... wrote:
> > PTAL. In addition to this, there are two more OSR errors on mips64 to be
> tracked
> > down, and fixed in separate CL.
> 
> Probably due to some frame layout details or some preserved register that I
> overlooked. Are the frames on MIPS64 laid out significantly differently than
on
> MIPS?

I mistakenly attributed 2 TF test fails here. They surfaced after
https://codereview.chromium.org/1018853003, and Dusan just fixed the problem in
https://codereview.chromium.org/1038173003. Nothing to do with frame layout or
any of your changes. FYI, JS frames are laid out the same on both MIPS & MIPS64.
C frames are a bit different due to ABI.

Powered by Google App Engine
This is Rietveld 408576698