Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 1018853003: [turbofan] add non fixed slot constraint to register allocator (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] add non fixed slot constraint to register allocator R=jarin@chromium.org BUG= Committed: https://crrev.com/0a835afb29eedfc266ecb230cf27b8211b1d0b06 Cr-Commit-Position: refs/heads/master@{#27373}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -59 lines) Patch
M src/compiler/instruction.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 4 5 6 7 8 9 5 chunks +22 lines, -9 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 6 7 8 9 13 chunks +97 lines, -43 lines 0 comments Download
M src/compiler/register-allocator-verifier.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 2 3 4 5 6 7 8 3 chunks +17 lines, -1 line 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dcarney
ptal
5 years, 9 months ago (2015-03-23 09:27:47 UTC) #2
Jarin
ouch, my eyes! lgtm (with eyes closed).
5 years, 9 months ago (2015-03-23 10:38:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018853003/180001
5 years, 9 months ago (2015-03-23 12:38:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4104)
5 years, 9 months ago (2015-03-23 12:58:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018853003/200001
5 years, 9 months ago (2015-03-23 15:40:06 UTC) #10
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years, 9 months ago (2015-03-23 16:03:18 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 16:03:28 UTC) #12
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/0a835afb29eedfc266ecb230cf27b8211b1d0b06
Cr-Commit-Position: refs/heads/master@{#27373}

Powered by Google App Engine
This is Rietveld 408576698