Don't check connectivity if network is offline.

chromecast/net/connectivity_checker.cc

Index: chromecast/net/connectivity_checker.cc
diff --git a/chromecast/net/connectivity_checker.cc b/chromecast/net/connectivity_checker.cc
index e6e1b409867f5ee374d2cbc1fba68a3a60ad5b0d..de3081291f3e2e71b2b25757b05af569871d756f 100644
--- a/chromecast/net/connectivity_checker.cc
+++ b/chromecast/net/connectivity_checker.cc
@@ -105,6 +105,11 @@ void ConnectivityChecker::Check() {
   }
   DCHECK(url_request_context_.get());
 
+  // Don't check connectivity if network is offline, because internet could be
+  // accessible via netifs ignored.
+  if (net::NetworkChangeNotifier::IsOffline())

[derekjchow1, 2015/03/25 22:37:26]

I don't think we should check here. What happens for non-test situations?
I think the following can occur.:

1) Ethernet plug gets pulled
2) Connection type is changed to NONE
3) OnConnectionTypeChanged calls Check
4) Check returns prematurely

SetConnectivity(false) is never called in this process.

[byungchul, 2015/03/25 22:44:39]

SetConnectivity(false) is called by OnConnectionTypeChanged().

+    return;
+
   // If url_request_ is non-null, there is already a check going on. Don't
   // start another.
   if (url_request_.get())