Don't check connectivity if network is offline.

chromecast/net/connectivity_checker.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/net/connectivity_checker.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "chromecast/net/net_switches.h"
@@ skipping 87 matching lines @@
 }
 
 void ConnectivityChecker::Check() {
   if (!loop_proxy_->BelongsToCurrentThread()) {
     loop_proxy_->PostTask(FROM_HERE,
                           base::Bind(&ConnectivityChecker::Check, this));
     return;
   }
   DCHECK(url_request_context_.get());
 
+  // Don't check connectivity if network is offline, because internet could be
+  // accessible via netifs ignored.
+  if (net::NetworkChangeNotifier::IsOffline())

[derekjchow1, 2015/03/25 22:37:26]

I don't think we should check here. What happens for non-test situations?
I think the following can occur.:

1) Ethernet plug gets pulled
2) Connection type is changed to NONE
3) OnConnectionTypeChanged calls Check
4) Check returns prematurely

SetConnectivity(false) is never called in this process.

[byungchul, 2015/03/25 22:44:39]

SetConnectivity(false) is called by OnConnectionTypeChanged().

+    return;
+
   // If url_request_ is non-null, there is already a check going on. Don't
   // start another.
   if (url_request_.get())
     return;
 
   VLOG(1) << "Connectivity check: url=" << *connectivity_check_url_;
   url_request_ = url_request_context_->CreateRequest(
       *connectivity_check_url_, net::MAXIMUM_PRIORITY, this);
   url_request_->set_method("HEAD");
   url_request_->Start();
@@ skipping 19 matching lines @@
 void ConnectivityChecker::OnResponseStarted(net::URLRequest* request) {
   int http_response_code =
       (request->status().is_success() &&
        request->response_info().headers.get() != NULL)
           ? request->response_info().headers->response_code()
           : net::HTTP_BAD_REQUEST;
 
   // Clears resources.
   url_request_.reset(NULL);  // URLRequest::Cancel() is called in destructor.
 
   if (http_response_code < 400) {

[derekjchow1, 2015/03/25 22:37:26]

Perhaps we should check (http_response_code < 400 &&
!net::NetworkChangeNotifier::IsOffline()) here?

     VLOG(1) << "Connectivity check succeeded";
     bad_responses_ = 0;
     SetConnectivity(true);
     return;
   }
 
   VLOG(1) << "Connectivity check failed: " << http_response_code;
   ++bad_responses_;
   if (bad_responses_ > kNumBadResponses) {
     bad_responses_ = kNumBadResponses;
@@ skipping 12 matching lines @@
 }
 
 void ConnectivityChecker::Cancel() {
   if (url_request_.get()) {
     VLOG(2) << "Cancel connectivity check in progress";
     url_request_.reset(NULL);  // URLRequest::Cancel() is called in destructor.
   }
 }
 
 }  // namespace chromecast